PHP: Do not prepend a whitespace when encoding body as multipart form data #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data
When Playground request handler is called with a key: value object as
its body, that data is encoded as a multipart string:
```ts
await playground.request({
url: `/wp-admin/import.php`,
method: 'POST',
body: { import: file },
});
```
However, the `encodeAsMultipart()` function prepended one newline too
many at the beginning of each multipart section.
Most of Playground do not use the `key: value` notation and just pass
the POST data as bytes, which is why the normal operating functions were
preserved.
However, the importFile step relied on the `key: value` notation.
Importing WXR involves submitting a form with a nonce. However, the
nonce contained an extra whitespace and was rejected by WordPress. This
PR ensures that extra whitespace isn't there.
## Testing instructions
* Ensure the CI tests pass
adamziel
added
[Type] Bug
adamziel
added a commit
that referenced
this pull request
Feb 13, 2024
…rt file step A follow up to #1033 I noticed the import file step won't throw clear error information so this PR adds some. In addition, it sets the progress bar caption to "Importing content"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Playground request handler is called with a key: value object as its body, that data is encoded as a multipart string:
However, the
encodeAsMultipart()function prepended one newline too many at the beginning of each multipart section.Most of Playground do not use the
key: valuenotation and just pass the POST data as bytes, which is why the normal operating functions were preserved.However, the importFile step relied on the
key: valuenotation. Importing WXR involves submitting a form with a nonce. However, the nonce contained an extra whitespace and was rejected by WordPress. This PR ensures that extra whitespace isn't there.Testing instructions