Fix php bison dep for building on non-arm64 architectures #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prebuilt bison 2.7 files are for arm64 architecture and do not work for other architectures such as x86_64. In these cases, we can at least build bison 2.7 from source. We could be more efficient and build a version that is cached across all PHP builds that need it, but let's get the builds working again first.
|
Works like a charm on arm64. I couldn't test on intel, but the change looks good and I understand it enabled building the project on your machine 👍 |
|
Thank you, @adamziel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR is an alternative to PR #871.
This PR fixes an error building php-wasm for PHP 7.3 and below on non-arm64 architectures. Those PHP versions depend on Bison 2.7. We have a prebuilt version of Bison 2.7 for arm64, but that naturally doesn't work on other CPU architectures. This PR builds Bison 2.7 as a stopgap.
On non-arm64 architectures, this extra build step runs once for each supported PHP version up to PHP 7.3. This is not ideal but can be improved later.
Testing Instructions
Before applying this patch
On an intel machine, run
npm run recompile:php:weband observe there is a build error.After applying this patch
On an intel machine, run
npm run recompile:php:weband observe there are no longer build errors.On an arm64 machine, run the following to make sure there are no build regressions:
npm run recompile:php:web