Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix experimental notice in FF ESR #1117

Merged

Conversation

brandonpayton
Copy link
Member

What is this PR doing?

Fixes #1106 where the experimental notice takes over most of the content area.

Screenshot 2024-03-14 at 11 06 52 AM

What problem is it solving?

The experiemental-and-fun notice is styled with nested CSS which is not supported by Firefox ESR v115.x. Firefox v117.x introduced CSS nesting support.

How is the problem addressed?

This PR removes use of nested CSS for now.

Testing Instructions

  • Install and launch Firefox ESR v115.x
  • Run npm run dev
  • Navigate to http://localhost:5400/website-server/ and observe the large notice
  • If the notice is missing, clear cookies for the current site and reload the page.
  • Apply this patch
  • Clear cookies for the current site, reload the page, and observe the notice is displayed reasonably at the bottom of the screen.
image NOTE: Playground is failing to load in FF ESR from localhost, but it is likely unrelated. This is just a CSS change, and the problem occurs on both trunk and this branch.

Avoid nested CSS for now because FF ESR v115 does not support it.
@adamziel adamziel merged commit 80201b4 into WordPress:trunk Mar 19, 2024
5 checks passed
@adamziel
Copy link
Collaborator

This is lovely, thank you @brandonpayton! This will auto-deploy at 9am utc

@brandonpayton brandonpayton deleted the fix-experimental-warning-for-ff-esr branch March 19, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"cool fun experimental" notice creates a somewhat unusable experience in Firefox
2 participants