Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123
What is this PR doing?
It adds rate limiting to the logger API.
What problem is it solving?
Increases protection from spam requests.
How is the problem addressed?
By tracking the number of requests in
$_SESSION
and returning early if the limit was reached.Testing Instructions
logger.php
file to a PHP local server or start a Docker serverKnown limitations
Because this is implemented using
$_SESSION
it can easily be worked around usingcurl
or by removing session data.To improve rate limiting we would need support for storing request counts by IP on the server and there is currently no storage support except for files.