importWxr: Preserve backslashes in the imported content #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
dmsnell
reviewed
Apr 8, 2024
|
|
||
| const expectedPostContent = `<!-- wp:inseri-core/text-editor {"blockId":"DSrQIjN5UjosCHJQImF5z","blockName":"textEditor","height":60,"content":"\\u0022#test\\u0022","contentType":"application/json"} --> | ||
| <div class="wp-block-inseri-core-text-editor" data-attributes="{"blockId":"DSrQIjN5UjosCHJQImF5z","blockName":"textEditor","content":"\\"#test\\"","contentType":"application/json","editable":false,"height":60,"isVisible":true,"label":""}">is loading ...</div> | ||
| <!-- /wp:inseri-core/text-editor -->`; |
There was a problem hiding this comment.
given that these are encoding tests, I could see some value in storing this in a file as well. it seems like you properly encoded \\u0022 so that it turns into \u0022, but it's easy to get lost quickly in the levels of encoding and display
There was a problem hiding this comment.
Aha, that's a good point!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Preserves the backslashes in the content imported through
importWxrby callingwp_slashon the entire imported data.This issue started after the recent switch to the
humanmade/wordpress-importerin #1192. Turns out that importer doesn't callwp_slashon its own.Closes #1211
Testing Instructions
Confirm the unit tests pass.
cc @aplamada @dmsnell