Catch DNS errors to avoid unhandled exceptions #1215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Catches potential DNS errors produced in outbound network requests to avoid unhandled exceptions.
What problem is it solving?
Fixes the problem described in #535.
How is the problem addressed?
The PR introduces a
try-catch
statement to catch errors produced when invokinglookup
to resolve the target host address. When this happens, it sends empty binary data as a notification that the connection initiated but soon after, it closes the connection with error code3000
.Testing Instructions
The original issue references
wp-now
, so it's recommended to test the changes using a local build ofwp-now
from theplayground-tools
repository.wordpress-playground
repository, runnx build php-wasm-node
.playground-tools
repository.playground-rools
repository, update the@php-wasm/node
dependency to point to the local path of thewordpress-playground
repository.Example:
npm i
.nx build wp-now
.node dist/packages/wp-now/cli.js start
./wp-admin
).wp-now
doesn't crash./wp-admin/plugin-install.php
.wp-now
doesn't crash./wp-admin/update-core.php
wp-now
doesn't crash.Note
It's recommended to disable the network cache in your browser via the DevTools Network tab.