Request Handler: Urldecode the requested path #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies decodeURIComponent() to dispatched paths in PHPRequestHandler. It solves the following problem: If you try to upload a file with dots followed by spaces in the filename it won't be recognized and the file will not be uploaded. Closes #1202 ## Testing instructions * Go through steps from #1202 * Confirm the unit tests pass
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies decodeURIComponent() to dispatched paths in PHPRequestHandler.
It solves the following problem: If you try to upload a file with dots followed by spaces in the filename it won't be recognized and the file will not be uploaded.
Closes #1202
Testing instructions