-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the networking disabled error messages in wp-admin for plugins and themes #936
Update the networking disabled error messages in wp-admin for plugins and themes #936
Conversation
...ound/blueprints/src/lib/steps/apply-wordpress-patches/wp-content/mu-plugins/0-playground.php
Outdated
Show resolved
Hide resolved
Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test:
|
...ound/blueprints/src/lib/steps/apply-wordpress-patches/wp-content/mu-plugins/0-playground.php
Outdated
Show resolved
Hide resolved
Hi @adamziel, here's hoping this time it's okay :-) Also found a hacky solution for this:
and this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @ironnysh! I think it's good to merge. I'll give it one more look tomorrow and then merge.
Yay! Thanks for your patience and support 🤓 |
What is this PR doing?
Displays a revised error message when trying to install a new plugin or theme while networking is disabled (the default state). See #927.
What problem is it solving?
The current version of the error message doesn't include an explanation on how to enable networking.
How is the problem addressed?
Suggests two possible ways to solve the problem, including examples and links to the documentation.
Testing Instructions
Launch a Playground instance, navigate to Add Themes or Add Plugins, and see the error message.