Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the networking disabled error messages in wp-admin for plugins and themes #936

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

ironnysh
Copy link
Collaborator

What is this PR doing?

Displays a revised error message when trying to install a new plugin or theme while networking is disabled (the default state). See #927.

What problem is it solving?

The current version of the error message doesn't include an explanation on how to enable networking.

How is the problem addressed?

Suggests two possible ways to solve the problem, including examples and links to the documentation.

Testing Instructions

Launch a Playground instance, navigate to Add Themes or Add Plugins, and see the error message.

@adamziel
Copy link
Collaborator

Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test:

it('should disable networking when requested', () => {
cy.visit('/?url=/wp-admin/plugin-install.php');
cy.wordPressDocument()
.find('.notice.error')
.should('contain', 'Enable networking support in Playground');
});

mk520888

This comment was marked as spam.

mk520888

This comment was marked as spam.

@ironnysh
Copy link
Collaborator Author

Hi @adamziel, thanks for your help! Let me know if anything is missing :-)

Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test:

@ironnysh
Copy link
Collaborator Author

Hi @adamziel, here's hoping this time it's okay :-)

Also found a hacky solution for this:

Hmm, the button is part of core. Is there a way to hide it?

and this:

The error message appears twice on the Featured plugins tab.

@ironnysh ironnysh requested a review from adamziel January 21, 2024 14:37
Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @ironnysh! I think it's good to merge. I'll give it one more look tomorrow and then merge.

@adamziel adamziel merged commit eb1a0a4 into WordPress:trunk Jan 23, 2024
5 checks passed
@ironnysh
Copy link
Collaborator Author

Yay! Thanks for your patience and support 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants