Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit shows Warning message "The configuration file did not pass validation!" #369

Closed
mukeshpanchal27 opened this issue Jan 2, 2024 · 3 comments
Labels
Infrastructure Issues for the overall plugin infrastructure [Type] Bug An existing feature is broken

Comments

@mukeshpanchal27
Copy link
Member

I observed some warning messages related to unit tests. Starting from PHP 7.1, we've been encountering these messages. You can find the details here: https://github.com/WordPress/plugin-check/actions/runs/7281778666.

Warning - The configuration file did not pass validation!
The following problems have been detected:

Line 9:
- Element 'coverage': This element is not expected.

Test results may not be as expected.

And another is:

Warning - The configuration file did not pass validation!
The following problems have been detected:

Line 25:
- Element 'filter': This element is not expected.

Test results may not be as expected.
@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall plugin infrastructure labels Jan 2, 2024
@mukeshpanchal27
Copy link
Member Author

The phpunit.xml.dist and tests/phpunit/multisite.xml were updated in #321 and added coverage and filter tags.

cc. @eclarke1 @felixarntz @swissspidy @joemcgill

@swissspidy
Copy link
Member

Since we have to run tests with multiple PHPUnit versions I don't think it's possible to have a single config file format that works for all versions without warnings. So this is expected IMHO and not a big deal. Just warnings.

@felixarntz
Copy link
Member

+1 to @swissspidy's feedback, I don't think this is crucial enough to go through the hassle of multiple config files. I would suggest we close this as not planned.

@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure [Type] Bug An existing feature is broken
Projects
None yet
Development

No branches or pull requests

3 participants