Rename theme to TT1 Blocks #145
Conversation
| @@ -68,7 +68,7 @@ function twenty_twenty_one_register_block_styles() { | |||
| 'core/latest-posts', | |||
| array( | |||
| 'name' => 'twentytwentyone-latest-posts-dividers', | |||
There was a problem hiding this comment.
I left these as since the pattern is a Twenty Twenty-One pattern...
There was a problem hiding this comment.
I left these originally, and I think it's probably ok to keep as is here too. The benefit is that if someone were to switch from the original Twenty Twenty-One to this one, any blocks using those custom styles would still work, since this theme ships with CSS that targets the same classnames.
| @@ -0,0 +1,5 @@ | |||
| <!-- wp:template-part {"slug":"header","theme":"tt1-blocks","align":"full", "tagName":"header","className":"site-header"} /--> | |||
There was a problem hiding this comment.
Wait I see its deleted below... weird.
There was a problem hiding this comment.
That is weird, I wonder why github didn't catch that it was a file rename.
|
We'll also want to change the screenshot probably, though we can handle that in a separate PR. |
|
We have confirmation that the theme slug is available. |
|
With Gutenberg version 9.5.2, the template parts in the site editor are not loading, I only see the spinner. I am using Windows 10, Firefox version 84.0, Chrome version 87.0.4280.88 |
|
Tested again with the current master of Gutenberg 9.6 RC1 (5425353), but the result was the same.
|
|
@carolinan can you reset your database in your testing environment? I'm not sure if something is affected by some template resolution change or something... - needs to be checked. https://developer.wordpress.org/block-editor/packages/packages-env/#5-reset-the-database |
|
I was seeing this at some point with Gutenberg, but on the latest master it works fine. |
|
It might probably caused by this: WordPress/gutenberg#27016 (breaking changes). I think it's okay to merge. |
|
If it works for scruffian that is the confirmation I need to merge it :) |
This PR addresses the name change part of #140.
Based on the discussion in the recent block-based themes meeting, folks seemed okay with the name "TT1 Blocks".
Note that we will need to follow up with a Gutenberg PR to address some tests there: https://github.com/WordPress/gutenberg/search?q=twentytwentyone-blocks
To test
One question — could we update the theme screenshot to somehow visually represent that this is not the same theme as Twenty Twenty-One?