TT1 Blocks: Clean up for Theme Repo #149

kjellr · 2020-12-17T13:43:34Z

Takes care of a few of the checklist items from #140 (comment):

Update screenshot
Update the remaining @subpackage
Add file header to functions.php

I also added a first draft of a readme.txt. Please suggest any edits!

For the screenshot, this was a (very) quick version. @melchoyce I'm curious if you have any ideas. I'm not sure how totally different we want the screenshot, considering it's meant to be the exact same theme visually. 😄

Original	TT1 Blocks

kjellr · 2020-12-17T13:44:06Z

tt1-blocks/readme.txt

+
+== Changelog ==
+
+= 1.0 =


I'm not sure what to do about the version number here. Should we start below 1.0?

Works for me. Updated in 582d892.

tt1-blocks/readme.txt

melchoyce · 2020-12-17T16:58:31Z

How about including the tagline and showing a little more of the image?

kjellr · 2020-12-17T17:05:02Z

Works for me, thanks! PR is updated.

kjellr · 2020-12-17T19:29:05Z

I just pushed up archive and search results templates:

Archive	Search Results

Note that the search and archive page titles are static because dynamic blocks for those titles don't exist yet. That will eventually be handled by the "Query Title" block as noted in WordPress/gutenberg#22724.

I'm not 100% sure about the query block markup there, but it seems to work in my testing. Also note that I think Gutenberg 9.6 is required to get these queries working.

kjellr · 2020-12-17T19:40:56Z

If those templates look good, I think this will now close #140.

jffng · 2020-12-17T22:12:41Z

I tested the Archive and Search templates against GB master, and looks good to me.

scruffian · 2020-12-18T10:16:30Z

Is there a reason that we need these extra templates? If we need them, maybe we could create another template part which contains the code that is shared across all these templates?

kjellr · 2020-12-18T13:38:58Z

Until the page headers are dynamic, I'm not sure it makes sense to include these additional templates at all — they're basically just the same as the index template (I can easily modify the query there instead of on these two pages, and it will work in all contexts).

@carolinan, you'd included these two templates in your list here. What do you think?

- Tidy up the query itself. - Fix wide/full styles for inner content in the query block.

scruffian · 2020-12-18T14:08:56Z

tt1-blocks/style.css

@@ -46,7 +46,8 @@ body {
 }

 .wp-site-blocks > *:not(.wp-block-post-content),
-.wp-site-blocks .wp-block-post-content > * {
+.wp-site-blocks .wp-block-post-content > *,
+.wp-block-query-loop li > *:not(.entry-content):not(.alignwide):not(.alignfull) {


did this creep in by mistake?

No, I just added that. Previously, all content of the query block was showing up as standard width, even when it was wide/full. 😩 I noticed this when I moved the default query into its own template part, and had to do this to fix it.

Here's an example, where the Media & Text block is supposed to be wide width:

Before f4a0131 After I placed the query block in the full-width template part. Final result, after I added this css.

(I really can't wait until this alignments stuff "just works" 😞).

kjellr · 2020-12-18T14:16:49Z

BTW, I fixed the global query in f4a0131 by using the usual query block markup, and ensuring that it was set to "inherit":true (Thanks @ntsekouras for the help). Now the index, archive, and search templates all use the same exact query.

These are already defined in theme.json.

kjellr · 2021-01-04T15:24:45Z

In functions.php line 216 this text domain is incorrect:

Thanks, should be fixed now.

If there is any code borrowed from for example Bosco, Gutenberg starter theme, Q or emptytheme then those themes and theme developers should be credited too.

I don't think there is anymore. The alignments came from here originally, but they've been rewritten by @scruffian recently. The rest of the base of the theme was just built from scratch or copy/pasted from the original Twenty Twenty-One.

I don't think these two are needed since they are also set in the json file?

Good call. 👍

This should be ready for another review!

carolinan · 2021-01-05T05:58:10Z

There are functions in the removed header.php and footer.php files that are needed to pass theme check for the upload to the theme directory.

carolinan · 2021-01-05T06:29:11Z

@Otto42 since this theme will be added to the theme directory from the wordpressorg account does it still need to pass theme check?

carolinan · 2021-01-05T06:47:08Z

The post comments block uses comments_template so the theme still needs a comments.php file:

Deprecated: Theme without comments.php is deprecated since version 3.0.0 with no alternative available. Please include a comments.php template in your theme. in /var/www/html/wp-includes/functions.php on line 5059

Update:
I made a separate PR for thi,s #157 because I'm not really happy with adding that much extra CSS. The purpose is only to make sure that the comments are working.

kjellr · 2021-01-05T13:35:45Z

There are functions in the removed header.php and footer.php files that are needed to pass theme check for the upload to the theme directory.

It's possible I added those intentionally and forgot why over the holidays. 😄

In any case, even with those files, the theme fails ThemeCheck with a ton of errors:

So if it does need to pass ThemeCheck, we need to add many more (unused) selectors and functions. If possible, it would be a much better solution to fix ThemeCheck so it doesn't require all this stuff for block based themes.

carolinan · 2021-01-05T13:53:51Z

Without finalized requirements we can't update Theme Check -we won't know what it needs to check for. I estimate that to take at least 3 months.

(The required CSS classes listed there has been removed but that plugin version has not been released yet.)

scruffian · 2021-01-05T14:15:24Z

There are other Block Themes in the directory that didn't pass the check...

carolinan · 2021-01-05T15:22:28Z

Ah, no that is not how the theme upload works, you have have to pass Theme Check once.
Once the theme data is saved (it is a custom post type) and the files are uploaded, the moderators need to log in and enable a "Special Case Theme" setting in the admin area. This means that theme is not checked by Theme Check on the next upload.
After that, the files can be removed from the theme.

That is why I wanted to ask Otto because I believe he mentioned that there is an exception for default themes. This is not a default or bundled theme but it will be uploaded from the same account.

kjellr · 2021-01-05T15:32:05Z

Ok cool. I think the plan was to upload a generic theme with the TT1 Blocks name to start with (a version that passes ThemeCheck), and then once a moderator enables that special case, we can upload the actual version. That should work, right?

carolinan · 2021-01-05T15:38:15Z

Yes.

kjellr · 2021-01-05T15:40:50Z

Cool. If that's the case, I think we can leave out those header.php and footer.php files. If folks are ok with the rest of what's in this PR, we should be able to get the submission process moving soon.

carolinan · 2021-01-06T08:16:01Z

I was hoping to be able to merge this now but when I view an archive or search result I see the following:

Warning: A non-numeric value encountered in /var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/query-loop.php on line 45

Line 45 is the per page setting:
https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/query-loop/index.php#L45

In index.html, the per page setting is "query":{"perPage":"",

I am not sure if it has been discussed already but the default value for $posts_per_page is 10 and I think this should reflect that.

Update the perPage setting in the query

tt1-blocks/block-templates/index.html

carolinan · 2021-01-06T08:41:54Z

Has the lack of query pagination been discussed? Is not including pagination something you feel as strongly about as the comments?

The pagination does not have a CSS class on the front so we can not add any styles for it until the block is updated. But navigating between the archive pages technically works.

scruffian · 2021-01-06T09:47:48Z

There are a couple of open issues for pagination:
WordPress/gutenberg#26557
WordPress/gutenberg#24762

carolinan · 2021-01-06T10:38:12Z

Yes but they do not address why the block is not being used in the theme.

scruffian · 2021-01-06T12:42:52Z

I created an issue to add the block to this theme: #158

kjellr · 2021-01-06T14:27:11Z

Yes but they do not address why the block is not being used in the theme.

There's a simple answer actually: I tried adding it a while back, but it didn't seem to work. 😂

Let's look at sorting that out in another PR — maybe it's working now.

kjellr added 6 commits December 17, 2020 08:04

Add file header to functions.php

a04b295

Update subpackage.

4f408f3

Update version numbers.

dc3d8a1

Add readme

0679497

Add initial version of README

735accb

Update screenshot.png

b01ed22

kjellr added the enhancement New feature or request label Dec 17, 2020

kjellr requested review from scruffian, jffng and carolinan December 17, 2020 13:43

kjellr self-assigned this Dec 17, 2020

kjellr commented Dec 17, 2020

View reviewed changes

kjellr changed the title ~~Tt1/cleanup for release~~ TT1 Blocks: Clean up for Theme Repo Dec 17, 2020

jffng reviewed Dec 17, 2020

View reviewed changes

tt1-blocks/readme.txt Show resolved Hide resolved

kjellr added 2 commits December 17, 2020 09:29

Bump required version.

55deebb

Change version numbers.

582d892

Update screenshot.

e4e2875

Add Archive and Search templates.

ab48c37

Add archive title.

cbaa3dc

Move default query into its own template part.

f4a0131

- Tidy up the query itself. - Fix wide/full styles for inner content in the query block.

scruffian reviewed Dec 18, 2020

View reviewed changes

kjellr added 3 commits January 4, 2021 10:14

Fix textdomain.

d0cedb8

Remove exclude post id.

e199b52

Remove duplicate theme_support calls.

5fc3744

These are already defined in theme.json.

Remove header/footer that were added by mistake.

0dbdb25

Update the perPage setting in the query

cf56fe9

Update the perPage setting in the query

carolinan requested a review from scruffian January 6, 2021 08:21

carolinan reviewed Jan 6, 2021

View reviewed changes

tt1-blocks/block-templates/index.html Outdated Show resolved Hide resolved

Update tt1-blocks/block-templates/index.html

d62854b

scruffian mentioned this pull request Jan 6, 2021

TT1 Blocks: Add the query pagination block #158

Closed

scruffian mentioned this pull request Jan 6, 2021

Query Pagination Block warning WordPress/gutenberg#28014

Closed

carolinan merged commit 442cf33 into master Jan 7, 2021

scruffian deleted the tt1/cleanup-for-release branch January 7, 2021 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TT1 Blocks: Clean up for Theme Repo #149

TT1 Blocks: Clean up for Theme Repo #149

kjellr commented Dec 17, 2020

kjellr Dec 17, 2020

scruffian Dec 17, 2020

kjellr Dec 17, 2020

melchoyce commented Dec 17, 2020

kjellr commented Dec 17, 2020 •

edited

Loading

kjellr commented Dec 17, 2020 •

edited

Loading

kjellr commented Dec 17, 2020

jffng commented Dec 17, 2020

scruffian commented Dec 18, 2020

kjellr commented Dec 18, 2020

scruffian Dec 18, 2020

kjellr Dec 18, 2020

kjellr commented Dec 18, 2020

kjellr commented Jan 4, 2021

carolinan commented Jan 5, 2021

carolinan commented Jan 5, 2021

carolinan commented Jan 5, 2021 •

edited

Loading

kjellr commented Jan 5, 2021

carolinan commented Jan 5, 2021 •

edited

Loading

scruffian commented Jan 5, 2021

carolinan commented Jan 5, 2021

kjellr commented Jan 5, 2021

carolinan commented Jan 5, 2021

kjellr commented Jan 5, 2021

carolinan commented Jan 6, 2021

carolinan commented Jan 6, 2021 •

edited

Loading

scruffian commented Jan 6, 2021

carolinan commented Jan 6, 2021

scruffian commented Jan 6, 2021

kjellr commented Jan 6, 2021

TT1 Blocks: Clean up for Theme Repo #149

TT1 Blocks: Clean up for Theme Repo #149

Conversation

kjellr commented Dec 17, 2020

kjellr Dec 17, 2020

Choose a reason for hiding this comment

scruffian Dec 17, 2020

Choose a reason for hiding this comment

kjellr Dec 17, 2020

Choose a reason for hiding this comment

melchoyce commented Dec 17, 2020

kjellr commented Dec 17, 2020 • edited Loading

kjellr commented Dec 17, 2020 • edited Loading

kjellr commented Dec 17, 2020

jffng commented Dec 17, 2020

scruffian commented Dec 18, 2020

kjellr commented Dec 18, 2020

scruffian Dec 18, 2020

Choose a reason for hiding this comment

kjellr Dec 18, 2020

Choose a reason for hiding this comment

kjellr commented Dec 18, 2020

kjellr commented Jan 4, 2021

carolinan commented Jan 5, 2021

carolinan commented Jan 5, 2021

carolinan commented Jan 5, 2021 • edited Loading

kjellr commented Jan 5, 2021

carolinan commented Jan 5, 2021 • edited Loading

scruffian commented Jan 5, 2021

carolinan commented Jan 5, 2021

kjellr commented Jan 5, 2021

carolinan commented Jan 5, 2021

kjellr commented Jan 5, 2021

carolinan commented Jan 6, 2021

carolinan commented Jan 6, 2021 • edited Loading

scruffian commented Jan 6, 2021

carolinan commented Jan 6, 2021

scruffian commented Jan 6, 2021

kjellr commented Jan 6, 2021

kjellr commented Dec 17, 2020 •

edited

Loading

kjellr commented Dec 17, 2020 •

edited

Loading

carolinan commented Jan 5, 2021 •

edited

Loading

carolinan commented Jan 5, 2021 •

edited

Loading

carolinan commented Jan 6, 2021 •

edited

Loading