This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Header templates: move group block margin to padding instead #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
|
Closing in favor of #327. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272.
Since dynamic spacer block units will not be part of 5.9, this PR pursues an alternate fix for #272 that moves the unsupported margin values on the theme's dark headers to padding values on its (pre-existing) wrapper parent instead.
This is a little hard to find (since it's a variable, it currently shows up as an empty field in the editor), but it does allow the values to be editable. So it seems like a slight improvement at least.
Screenshot: