This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Try a static spacer underneath the header #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
commented
Jan 10, 2022
| <div class="wp-block-group"><!-- wp:group {"align":"full","style":{"elements":{"link":{"color":{"text":"var:preset|color|background"}}},"spacing":{"padding":{"top":"0px","bottom":"0px"},"margin":{"bottom":"var(--wp--custom--spacing--large, 8rem)"}}},"backgroundColor":"foreground","textColor":"background","layout":{"inherit":true}} --> | ||
| <div class="wp-block-group alignfull has-background-color has-foreground-background-color has-text-color has-background has-link-color" style="margin-bottom:var(--wp--custom--spacing--large, 8rem);padding-top:0px;padding-bottom:0px"><!-- wp:template-part {"slug":"header","tagName":"header","align":"wide"} /--> | ||
| <div class="wp-block-group"><!-- wp:group {"align":"full","style":{"elements":{"link":{"color":{"text":"var:preset|color|background"}}},"spacing":{"padding":{"top":"0px","bottom":"var(--wp--custom--spacing--large, 8rem)"}}},"backgroundColor":"foreground","textColor":"background","layout":{"inherit":true}} --> | ||
| <div class="wp-block-group alignfull has-background-color has-foreground-background-color has-text-color has-background has-link-color" style="padding-top:0px;padding-bottom:var(--wp--custom--spacing--large, 8rem)"><!-- wp:template-part {"slug":"header","tagName":"header","align":"wide"} /--> |
There was a problem hiding this comment.
You'll notice that I'm adding some bottom padding here. The bird image is supposed to have some padding underneath it, but it was removed erroneously at some point. 🤷♂️
The padding is still present in the pattern, as it should be. So I'm just adding it back in to the template too.
| Before | After |
|---|---|
 |
 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #325 and #319.
Closes #272.
This PR adds a static spacer block under the header to replace the unsupported margin value that was there previously. Ideally, this should be a dynamic value, but this is the best we can do for the moment since that's not landing in 5.9.
Using a static value produces more space than intended on mobile, but overall I think the usability enhancement makes it worthwhile for the initial release. This also makes for a more efficient transition to #325, once dynamic spacer units will be supported in a future minor release. I (somewhat regretfully) think this is the best path forward for the moment.
Editor:
Frontend:
(Front-end desktop views are identical to
trunk.)