Add inert polyfill to iframe #3906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 tasks
|
I am a little concerned that the files changed in Gutenberg are different from the files changed to backport to the WordPress core. |
|
No, this is correct. I think we need to match core and plugin function names. |
|
Currently reviewing for commit. |
hellofromtonya
approved these changes
Feb 1, 2023
|
Committed via https://core.trac.wordpress.org/changeset/55181. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket https://core.trac.wordpress.org/ticket/57552
Related Gutenberg PR: WordPress/gutenberg#47398
This PR injects the inert polyfill script for Firefox into the iframe editor instance as well. When you open the site editor, you will see that three new scripts have been added, as shown below:
@Mamaduka @ntsekouras @youknowriad