Pin the floating-ui package versions in package-lock.json #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
approved these changes
Jul 20, 2023
|
Thank you very much for this solution. @tellthemachines |
spacedmonkey
approved these changes
Jul 21, 2023
|
Committed to trunk in r56284. Pending testing on trunk to check the issue is fixed, we can then commit it to the release branch. |
|
committed in https://core.trac.wordpress.org/changeset/56289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid breaking updates.
Trac ticket: https://core.trac.wordpress.org/ticket/58847
Essentially copies the fix from the previous time we had this problem: #4155 (comment)
Hope we can make our popovers work with the latest versions of those packages before too much longer 😅 but given it's RC time again this seems like the safest option for now.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.