-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Hooks: Inject hooked blocks into modified templates and parts #5726
Block Hooks: Inject hooked blocks into modified templates and parts #5726
Conversation
cf34d15
to
20e9b2e
Compare
dafeaf9
to
9a122e3
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
9a122e3
to
bcf555f
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This is one of the major changes planned for 6.5 and has been in the works for a while. It has been discussed quite extensively on the accompanying ticket, and most work has happened on preparatory changesets such as https://core.trac.wordpress.org/changeset/57157 and WordPress/gutenberg#58553. Unit test coverage in this PR should ensure that it works properly. I'll commit shortly 🙂 |
Committed to Core in https://core.trac.wordpress.org/changeset/57594. |
Using the new technique of storing information about whether or not a hooked block should be considered for injection or not, extend said injection to encompass modified templates and parts.
Follow-up to #5712.
Trac ticket: https://core.trac.wordpress.org/ticket/59646
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.