Default fonts directory to wp-content/uploads/fonts

[matiasbenedetto]

What?

Default fonts directory to wp-content/uploads/fonts instead of wp-content/fonts.

Context links:

• Font Library: use /wp-content/fonts instead of /wp-content/uploads/fonts to store font assets. gutenberg#53965
• Reconsider placing uploaded fonts within the uploads directory gutenberg#59417
• https://make.wordpress.org/core/2024/03/07/unblocking-wp6-5-font-library-and-synced-pattern-overrides/
• https://make.wordpress.org/core/2024/03/21/font-library-update-storage-of-font-files/
• https://make.wordpress.org/core/2024/03/25/wordpress-6-5-release-delayed-1-week/

---

Trac ticket: https://core.trac.wordpress.org/ticket/60845

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Edit: Add third context link and trac ticket -- @peterwilsoncc

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mmaattiiaass, peterwilsoncc, swissspidy, jorbin, davidbaumwald, johnbillion, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[aaronjorbin]

Initial testing is showing that fonts are correctly uploading to wp-content/uploads/fonts using both google fonts and manually uploading.

[johnbillion]

Can we get some tests added to confirm the expected path on Multisite sub-sites? It seems the expected path is wp-content/uploads/sites/<id>/fonts.

[peterwilsoncc]

This looks good to me.

I've confirmed _wp_upload_dir() assumes that formatting.php has been included so it's safe to do so in this code too.

I agree with @johnbillion that MS tests would be good too. I can push those if @matiasbenedetto isn't around or needs assistance

[aaronjorbin]

Left one minor documentation suggestion, but this is looking good to me

[desrosj]

Thanks everyone for turning this around so quickly. This looks good to go, in my opinion and worth merging to get some wider testing.

[peterwilsoncc]

Committed r57878 / f8e1870