Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background block supports: add support for top-level styles in theme.json #6482

Closed
wants to merge 8 commits into from
Closed

Background block supports: add support for top-level styles in theme.json #6482

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4053da3
Initial commit:
ramonjd May 2, 2024
956899d
Syncing https://github.com/WordPress/gutenberg/pull/59809
ramonjd May 2, 2024
e13fad2
unit tests
ramonjd May 3, 2024
8a7890e
Copy update
ramonjd May 3, 2024
9ff4495
Rolling back source requirement. File/URL is assumed by default until…
ramonjd May 8, 2024
a0a496d
Pulling change from https://github.com/WordPress/gutenberg/pull/61387
ramonjd May 26, 2024
bc314e1
Add @since annotation and remove null coalescing operator
ramonjd May 28, 2024
a254de9
Fix since annotation - remove line break.
ramonjd May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/wp-includes/class-wp-theme-json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2068,6 +2068,7 @@ protected static function flatten_tree( $tree, $prefix = '', $token = '--' ) {
* @since 6.1.0 Added `$theme_json`, `$selector`, and `$use_root_padding` parameters.
* @since 6.5.0 Output a `min-height: unset` rule when `aspect-ratio` is set.
* @since 6.6.0 Passing current theme JSON settings to wp_get_typography_font_size_value().
* Process background properties using the Style Engine.
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
*
* @param array $styles Styles to process.
* @param array $settings Theme settings.
Expand Down Expand Up @@ -2124,7 +2125,7 @@ protected static function compute_style_properties( $styles, $settings = array()
// Processes background styles.
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
if ( 'background' === $value_path[0] && isset( $styles['background'] ) ) {
$background_styles = wp_style_engine_get_styles( array( 'background' => $styles['background'] ) );
$value = $background_styles['declarations'][ $css_property ] ?? $value;
$value = isset( $background_styles['declarations'][ $css_property ] ) ? $background_styles['declarations'][ $css_property ] : $value;
}

// Skip if empty and not "0" or value represents array of longhand values.
Expand Down
Loading