Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser storage: Unhelpful crash message when outdated code is stored #1121

Open
adamziel opened this issue Mar 20, 2024 · 2 comments
Open
Labels
[Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing [Type] UI / UX / User Experience

Comments

@adamziel
Copy link
Collaborator

When the browser storage is selected and the stored code is outdated and no longer compatible with the current version of Playground, we should:

  • Provide a helpful error message stating the next steps
  • Enable the export of the stored content to avoid losing your work
  • Maybe? Try to auto-migrate within the constraints of the system

At the moment, you may see something like this and scratch your head thinking "Playground is broken":

Warning: require(/wordpress/wp-content/mu-plugins/playground-includes/wp_http_fetch.php): Failed to open stream: No such file or directory in /wordpress/wp-content/mu-plugins/0-playground.php on line 114

Fatal error: Uncaught Error: Failed opening required '/wordpress/wp-content/mu-plugins/playground-includes/wp_http_fetch.php' (include_path='.:') in /wordpress/wp-content/mu-plugins/0-playground.php:114 Stack trace: #0 /wordpress/wp-settings.php(2): include_once() #1 /wordpress/wp-config.php(101): require_once('/wordpress/wp-s...') #2 /wordpress/wp-load.php(2): require_once('/wordpress/wp-c...') #3 /wordpress/wp-blog-header.php(2): require_once('/wordpress/wp-l...') #4 /wordpress/index.php(2): require('/wordpress/wp-b...') #5 {main} thrown in /wordpress/wp-content/mu-plugins/0-playground.php on line 114
@adamziel adamziel added this to the Zero Crashes milestone Mar 20, 2024
@adamziel adamziel added [Type] Enhancement New feature or request [Type] UI / UX / User Experience [Type] Reliability Playground uptime, reliability, not crashing labels Mar 20, 2024
@adamziel
Copy link
Collaborator Author

Idea from @brandonpayton: Run an integrity check in the browser mode to confirm we're on the latest version before running the code. This sounds related to #566

@adamziel
Copy link
Collaborator Author

adamziel commented May 16, 2024

Boot protocol will solve this. It will prevent Playground from creating new files within the WordPress directory structure. Instead, it will load them from scratch on each boot which means they'll never get stale.

@adamziel adamziel mentioned this issue May 16, 2024
1 task
@adamziel adamziel moved this to Future work in Playground Board Jul 1, 2024
@adamziel adamziel removed this from the Zero Crashes milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing [Type] UI / UX / User Experience
Projects
None yet
Development

No branches or pull requests

1 participant