Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'engines' declaration in all relevant package.json files #449

Closed
danielbachhuber opened this issue May 25, 2023 · 3 comments
Closed
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request

Comments

@danielbachhuber
Copy link
Member

danielbachhuber commented May 25, 2023

From #434 (comment)

Done is:

  • The 'engines' declaration is added to the root package.json file and all 'package.json' files in the packages directory.
@adamziel
Copy link
Collaborator

adamziel commented Jun 2, 2023

The required node.js version is:

{
  "engines": {
    "node": ">=16"
  }
}

I'm not sure about the required npm version, this would need to be checked.

@adamziel adamziel added [Type] Enhancement New feature or request Good First Issue Good for newcomers labels Jun 2, 2023
@r-chrzan
Copy link
Contributor

r-chrzan commented Jun 8, 2023

Hi, i was trying to install deps on a node v17 and npm 8.6 and it turn out that it didn't works. I had to upgrading node up to 18.16.0 and npm to 9.5.1

r-chrzan pushed a commit to r-chrzan/wordpress-playground that referenced this issue Jun 8, 2023
r-chrzan pushed a commit to r-chrzan/wordpress-playground that referenced this issue Jun 8, 2023
@adamziel
Copy link
Collaborator

This issue was solved in 02543a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants