Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress build pipeline #8

Closed
adamziel opened this issue Sep 22, 2022 · 1 comment
Closed

WordPress build pipeline #8

adamziel opened this issue Sep 22, 2022 · 1 comment

Comments

@adamziel
Copy link
Collaborator

What problem is this issue looking to solve?

WebAssembly WordPress applies a few WordPress patches once it's started. The method is quite peculiar – a PHP code snippet reads these files from the in-memory filesystem, runs some str_replaces, and then writes these files back:

https://github.com/adamziel/wordpress-wasm/blob/9d04a113a97f53a1303fefba642f65f1b5a5a5f6/src/shared/wordpress.mjs#L128-L137

How does this issue proposes to solve it?

The bundling pipeline could be updated to also apply a few .patch files to WordPress. This way, WebAssembly environment would already boot with the patched version.

@adamziel
Copy link
Collaborator Author

36013ef switched from patching WordPress with eval() to JavaScript function calls. WordPress build pipeline exists in prepare-wordpress.sh and can be updated to apply arbitrary patches when needed. However, at the moment, patching via JavaScript seems to be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant