-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to crash reports #1253
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ccaa86c
Add context method
bgrgicak 0e8b73a
Collect context
bgrgicak 10f5e25
Collect worker metrics as context data
bgrgicak c127c95
Add context and blueprint to logger API request
bgrgicak 8d89ca4
Rename addFatalErrorListener
bgrgicak be6446c
Add context and blueprint sections to report
bgrgicak 1f07595
Count tabs instead of all clients
bgrgicak 653735a
Remove debug code
bgrgicak 40e3ab5
Revert url to production
bgrgicak 007ac3f
Merge branch 'trunk' into add/1152-logger-context
bgrgicak c37a47e
Address feedback
bgrgicak 2aeb4c2
Add comment to addServiceWorkerMessageListener
bgrgicak 7ea4013
Merge branch 'trunk' into add/1152-logger-context
bgrgicak 6786e9a
Update packages/php-wasm/logger/src/lib/logger.ts
bgrgicak 44c688b
Update packages/php-wasm/logger/src/lib/logger.ts
bgrgicak 0d86ce1
Update packages/php-wasm/logger/src/lib/logger.ts
bgrgicak e24aafd
Remove worker claim
bgrgicak 4c01ceb
Add comment about using includeUncontrolled
bgrgicak f7ccc23
Merge branch 'trunk' into add/1152-logger-context
bgrgicak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why includeUncontrolled? Let's leave a comment in the code to explain. Otherwise LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgrgicak yeah I meant more not the literal meaning of that option but rather why bother with uncontrolled clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update it in #1264 with something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but why an uncontrolled client is considered a Playground client? It seems like that browser tab wouldn't be able to access Playground anyway, as being controlled is crucial for that, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I tested this a bit and it's actually not needed, so I will remove this line in #1264