Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress PR Previewer: Simplify the Blueprint #1429

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented May 18, 2024

Replaces a series of custom steps meant to unzip and configure WordPress with passing the build zip as a preferredVersion. Here's what the updated Blueprint looks like:

{
	$schema:
		'https://playground.wordpress.net/blueprint-schema.json',
	landingPage: urlParams.get('url') || '/wp-admin',
	login: true,
	preferredVersions: {
		php: "7.4",
		wp: zipArtifactUrl
	}
};

Testing instructions

Replaces a series of custom steps meant to unzip and configure WordPress with passinf the build zip as a preferredVersion.

To test, go to the WordPress PR previewer locally and try previewing one of the recent PRs. Confirm the installed WordPress versions is indeed not the latest stable.

Do not merge until these PRs are merged:

* #1423 
* #1424 
* #1425 
* #1426 
* #1427
@adamziel adamziel changed the title WordPress PR Previewer: simplify the Blueprint WordPress PR Previewer: Simplify the Blueprint May 18, 2024
@adamziel adamziel marked this pull request as ready for review May 29, 2024 12:59
Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@adamziel adamziel merged commit caca49b into trunk Jun 3, 2024
5 checks passed
@adamziel adamziel deleted the adamziel-patch-1 branch June 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants