Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace search fork with Search block #13

Closed
iandunn opened this issue Oct 14, 2021 · 0 comments · Fixed by #155
Closed

Replace search fork with Search block #13

iandunn opened this issue Oct 14, 2021 · 0 comments · Fixed by #155
Labels
[Status] Blocked Can't move forward until something outside the issue/PR is resolved [Type] Developer Experience [Type] Enhancement New feature or request
Milestone
News: Post-launch...

Comments

@iandunn
Copy link
Member

iandunn commented Oct 14, 2021

we had to fork the search block in order to customize the url
xref #9 (comment)

once WordPress/gutenberg#35572 is fixed, the fork should be replaced with the actual block, along with the new attribute/filter
@iandunn iandunn added [Type] Enhancement New feature or request [Status] Blocked Can't move forward until something outside the issue/PR is resolved labels Oct 14, 2021
@iandunn iandunn added this to the After News launch milestone Oct 14, 2021
@iandunn iandunn modified the milestones: News: Post-launch iteration, News: External blockers Oct 27, 2021
@iandunn iandunn modified the milestones: News: External blockers, News: Post-launch iteration Dec 14, 2021
@dd32 dd32 mentioned this issue Jan 24, 2022
Closed
@ryelle ryelle mentioned this issue Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] Blocked Can't move forward until something outside the issue/PR is resolved [Type] Developer Experience [Type] Enhancement New feature or request
Projects
None yet
Milestone
News: Post-launch iteration 2
Development

Successfully merging a pull request may close this issue.

Search: Use search block with icon button WordPress/wporg-mu-plugins
1 participant
@iandunn