-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header/footer variation for white text on charcoal-1 #308
Comments
Just for consistency, I'd like to confirm that this is really needed from design — for example, the download counter is also a dark page, but it uses Here's a comparison of the existing dark header + background combo on the download counter.
Edit: What I'm trying to avoid here is an arbitrary set of header colors, all slightly different. |
I would think using charcoal-2 can work, but I'd let @panchovm confirm. |
Let's use the existing dark header. The |
Thanks! I'll close this issue then. |
The Enterprise website needs the charcoal-1 background color to be set in the header and footer, which currently isn't supported.
Created PR to add variation. @ryelle @StevenDufresne let me know if this needs any changes. It works well for me locally, but my local has had a few gremlins, so I'd love a second set of eyes.
#307
The text was updated successfully, but these errors were encountered: