Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header/footer variation for white text on charcoal-1 #308

Closed
bengreeley opened this issue Dec 8, 2022 · 4 comments
Closed

Add header/footer variation for white text on charcoal-1 #308

bengreeley opened this issue Dec 8, 2022 · 4 comments

Comments

@bengreeley
Copy link

The Enterprise website needs the charcoal-1 background color to be set in the header and footer, which currently isn't supported.

Created PR to add variation. @ryelle @StevenDufresne let me know if this needs any changes. It works well for me locally, but my local has had a few gremlins, so I'd love a second set of eyes.
#307

@ryelle
Copy link
Contributor

ryelle commented Dec 9, 2022

Just for consistency, I'd like to confirm that this is really needed from design — for example, the download counter is also a dark page, but it uses charcoal-2 as the main background, which matches the default dark header. Is it possible Enterprise could also use this, or do you think we'll need a charcoal-1 header for more pages? @jasmussen @javierarce

Here's a comparison of the existing dark header + background combo on the download counter.

Download Counter Enterprise
dlc ent

Edit: What I'm trying to avoid here is an arbitrary set of header colors, all slightly different.

@jasmussen
Copy link
Collaborator

I would think using charcoal-2 can work, but I'd let @panchovm confirm.

@fcoveram
Copy link
Collaborator

Let's use the existing dark header. The charcoal-1 is a mockup error. Thanks for the ping.

@ryelle
Copy link
Contributor

ryelle commented Dec 13, 2022

Thanks! I'll close this issue then.

@ryelle ryelle closed this as completed Dec 13, 2022
@ryelle ryelle closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants