-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header: Switch to submenu blocks for navigation items with submenus #210
Conversation
When the menu is truncated, the submenu is not reachable: menu-updates.mp4 |
); | ||
} | ||
|
||
$ouput = sprintf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a typo: $output
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏻
Thanks @ryelle ! I opened a PR upstream in Gutenberg which should fix up Escape key functionality. |
Ah, I bet when the menu item is cloned, the toggle looses the event listener. I've updated the style on submenus in the overflow menu so they'll always display to work around that. Also because 3rd-level flyouts are awkward :) I also updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good.
See WordPress/wporg-mu-plugins#210. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@11926 74240141-8908-4e6f-9713-ba540dce6ec7
Fixes #207 - Menu items with submenus should use the
navigation-submenu
block, this provides the expected markup for accessibility:aria-expanded="false"
by default, andtrue
when openThe remaining item on the list in #207 is this:
This menu doesn't seem to do that, but this doesn't seem to be core behavior either. I'd recommend opening an issue in gutenberg for the navigation block if this is required.
Props @alexstine.
Screenshots
In both of the videos below, I tab through the menu. In "before" you can see I tab down into the submenus with no other action. After, I need to activate the 🔽 button. There's no visual change, and no change in behavior with a mouse.
before.mp4
after.mp4