Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button styles: Line height is too large #152

Closed
ryelle opened this issue Sep 4, 2024 · 0 comments
Closed

Button styles: Line height is too large #152

ryelle opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels
[Component] Theme Templates, patterns, CSS

Comments

@ryelle
Copy link
Contributor

ryelle commented Sep 4, 2024

The buttons on wp.org and wp.org/download pages have the right padding (with just 2px of difference on the left and right sides). The difference between designs and production is the label's line-height. In the designs is 16px whereas in front is 1.7. That impacts the button's height.

I played with the value on the inspector, and a value of 1.3 looks good.

Originally posted by @fcoveram in WordPress/five-for-the-future#278 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Status: Done
Development

No branches or pull requests

1 participant