Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates to use new constrained layout setting #43

Closed
ryelle opened this issue Aug 31, 2022 · 1 comment
Closed

Update templates to use new constrained layout setting #43

ryelle opened this issue Aug 31, 2022 · 1 comment
Labels
[Component] Theme Templates, patterns, CSS priority: low This should happen sometime, but other things are more important

Comments

@ryelle
Copy link
Contributor

ryelle commented Aug 31, 2022

See WordPress/gutenberg#42763 — This new constrained layout type replaces the inherit: true setting in layout, and constrains the inner content to use the given content/wide width (vs no constraint = full screen width).

The new layout setting will be released with GB 14.0, though the old setting will probably be supported still (how long?)

We should update the parent & child templates (wporg-main-2022) to use this new setting.

I think the patterns in wporg-main-2022 would update automatically with the build:patterns script, but worth checking that too.

For example:

- <!-- wp:group {"layout":{"inherit":true}} -->
+ <!-- wp:group {"layout":{"type":"constrained"}} -->

("On Hold" because technically 14.0 is not out yet, but it should be released today)

@ryelle ryelle added [Status] On Hold [Component] Theme Templates, patterns, CSS priority: low This should happen sometime, but other things are more important and removed [Status] On Hold labels Aug 31, 2022
@ryelle
Copy link
Contributor Author

ryelle commented Jan 18, 2024

There are a bunch of these across wporg-developer-2023, wporg-developer-blog, wporg-documentation-2022, wporg-gutenberg, wporg-main-2022, & wporg-parent-2021, but fewer in the more-recent projects.

Inherit is still supported, and will continue to be. I think we can close this issue, let the updates happen naturally, and only worry about fixing it if it breaks.

@ryelle ryelle closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS priority: low This should happen sometime, but other things are more important
Projects
None yet
Development

No branches or pull requests

1 participant