chore: Add FormFieldGroup component and density example #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 1, 2024 10:05
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-ff-example
|
| Run status |
|
| Run duration | 03m 09s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
15
|
Pending
|
16
|
Skipped
|
0
|
Passing
|
854
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.64%
|
|
|---|---|
|
Untested elements
|
1783
|
|
Tested elements
|
490
|
Accessibility
99.21%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
229
|
…as-kit into mc-ff-example
modules/preview-react/form-field/stories/examples/AllFields.tsx
Outdated
Show resolved
Hide resolved
modules/preview-react/form-field/stories/examples/GroupedInputs.tsx
Outdated
Show resolved
Hide resolved
mannycarrera4
changed the title
mannycarrera4
changed the title
RayRedGoose
reviewed
Aug 30, 2024
modules/preview-react/form-field/stories/examples/GroupedInputs.tsx
Outdated
Show resolved
Hide resolved
RayRedGoose
reviewed
Aug 30, 2024
modules/preview-react/form-field/stories/examples/GroupedInputs.tsx
Outdated
Show resolved
Hide resolved
RayRedGoose
reviewed
Aug 30, 2024
Comment on lines
+139
to
+145
| {error && radioError | ||
| ? 'At least one topping and crust selection is required' | ||
| : error | ||
| ? 'You must choose at least one topping' | ||
| : radioError | ||
| ? 'You must choose a crust' | ||
| : ''} |
There was a problem hiding this comment.
Why not setting error message instead having error and radioError? It will be less validation
…s.tsx Co-authored-by: Raisa Primerova <48605821+RayRedGoose@users.noreply.github.com>
…s.tsx Co-authored-by: Raisa Primerova <48605821+RayRedGoose@users.noreply.github.com>
…as-kit into mc-ff-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2805, #2806, #2820, #2807
Release Category
Components
Release Note
Add new
FormFieldGroupcomponent to use when grouping inputs like checkboxes and radio inputs that need to be associated to one another. This component renders afieldsetandlegend. Its API matches theFormFieldAPI where you haveerrorprop as well asidandisRequired.We've added data attributes to Select so that you can customize styles more easily on elements that are not surfaced by the compound component API.
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)