Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk vulnerability: minimist #268

Closed
hspinks opened this issue Mar 24, 2020 · 4 comments
Closed

Snyk vulnerability: minimist #268

hspinks opened this issue Mar 24, 2020 · 4 comments
Labels
security Relating to security

Comments

@hspinks
Copy link
Collaborator

hspinks commented Mar 24, 2020

Snyk report finds a Medium Severity issue with minimist@0.0.8 introduced through react-scripts@3.4.0: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764

Snyk's suggested remediation:

Your dependencies are out of date, otherwise you would be using a newer minimist than minimist@0.0.8. Try relocking your lockfile or deleting node_modules, reinstalling and running snyk wizard. If the problem persists, one of your dependencies may be bundling outdated modules.

@hspinks hspinks added the security Relating to security label Mar 24, 2020
@hspinks hspinks added this to the v0.2 milestone Mar 24, 2020
@RohanTalip
Copy link
Contributor

RohanTalip commented Mar 24, 2020

@RohanTalip
Copy link
Contributor

RohanTalip commented Mar 24, 2020

@hspinks do you have a link to the full report? I'm curious what the path through the dependency tree from react-scripts@3.4.0 to minimist@0.0.8 is ... (as minimist@0.0.8 doesn't appear to be a direct dependency of react-scripts@3.4.0)

@hspinks
Copy link
Collaborator Author

hspinks commented Mar 25, 2020

@RohanTalip good question. here are the 2 paths:

whoapp@0.0.1 › react-scripts@3.4.0 › eslint-loader@3.0.3 › loader-fs-cache@1.0.2 › mkdirp@0.5.1 › minimist@0.0.8

and

whoapp@0.0.1 › react-scripts@3.4.0 › eslint-loader@3.0.3 › loader-fs-cache@1.0.2 › find-cache-dir@0.1.1 › mkdirp@0.5.1 › minimist@0.0.8

@RohanTalip
Copy link
Contributor

I'm guessing this can be closed since we're going with the Flutter implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Relating to security
Projects
None yet
Development

No branches or pull requests

3 participants