Jupyter polish #221
Merged
Jupyter polish #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative to the pywwt module, these files live in `nbextension/static`, not just `static`. Jupyter seems not to notice!
I hope. These are what have gotten things working for me with a fresh environment I was just setting up.
This limits the files included in the NPM package to just our JavaScript files. To the best of my understanding, these are the only ones we want. This reduces the size of the resulting tarball from 14M to 6k.
I believe that we need to do this to be compatible with the JupyterLab 1.0.x series. I don't fully understand what's going on, but changing this fixed a failure to load for me, with an error along the lines of "No provider for jupyterWidgetRegistry".
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 61.29% 61.29%
=======================================
Files 24 24
Lines 1912 1912
=======================================
Hits 1172 1172
Misses 740 740
Continue to review full report at Codecov.
|
|
Windows worked! There's one Travis failure with a weird transient-looking issue with the link-checking. |
Our `docs` directory doesn't use a `source/` subdirectory, so take that out of the Webpack config. Add the generated files to .gitignore. Seeing as this file wasn't landing in the right place and I don't see it referenced anywhere else in the repo, I suspect that it's not actually doing anything.
npm complains about security problems and, well, we just don't use these. We can add things back later, at more recent versions, if we need to.
Pytest 5.0, recently released, includes pytest-faulthandler built in, and trying to include it as an explicit dependency now results in a CI failure.
conda-forge hasn't been building packages for Python 3.5 for a while, so that installing the CI dependencies for that version has stopped working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of polish of the Jupyter packaging based on my adventures with a fresh Miniconda install. Note that JupyterLab 1.0 just came out a couple of weeks ago.