Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs to reflect time series additions #238

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Updated docs to reflect time series additions #238

merged 3 commits into from
Sep 25, 2019

Conversation

ojustino
Copy link
Contributor

I documented the additions I made in #187 -- time series capabilities in TableLayers and wwt.get_current_time().

@ojustino ojustino requested a review from pkgw September 25, 2019 01:17
@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   61.82%   61.82%           
=======================================
  Files          24       24           
  Lines        2038     2038           
=======================================
  Hits         1260     1260           
  Misses        778      778

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc30e3...dbe3a45. Read the comment docs.

pkgw
pkgw reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@pkgw pkgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! There are a couple of minor things to fix.

docs/layers.rst Outdated Show resolved Hide resolved
docs/layers.rst Outdated Show resolved Hide resolved
docs/layers.rst Outdated Show resolved Hide resolved
docs/layers.rst Outdated Show resolved Hide resolved
docs/settings.rst Outdated Show resolved Hide resolved
docs/views.rst Outdated Show resolved Hide resolved
@pkgw pkgw self-assigned this Sep 25, 2019
@ojustino ojustino requested a review from pkgw September 25, 2019 03:22
@ojustino
Copy link
Contributor Author

ojustino commented Sep 25, 2019 •
edited
Loading

Trying to pass some checks.

There were two links in layers.rst whose readable text began with astropy...; apparently RST doesn't like having multiple links with the same text. (This was a helpful find.) It might be worth adding an extra underscore to the end of our other links, too?

The most recent tests are failing because the link for Python requests on the installation page isn't working, and I can't currently open it myself either.

@pkgw
Copy link
Contributor

pkgw commented Sep 25, 2019

@ojustino We can ignore the failures related to the requests URLs; it's an issue that's likely transient and on their side. If all of the other tests are passing then things are OK.

@pkgw
docs/views.rst: fix description of get_current_time()
dbe3a45 
A copy/paste-o had us calling `set_current_time()`, and the crosslink markup
was missing backticks. Also remove some parentheses.
pkgw
pkgw approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@pkgw pkgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one more copy/paste-o that I fixed directly. I think this is good now.

@pkgw pkgw merged commit c08c9cd into WorldWideTelescope:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkgw pkgw pkgw approved these changes

Assignees

@pkgw pkgw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojustino @pkgw