Work on packaging metadata #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We compile our TypeScript to ESM syntax, so we that's what we should do in the current ecosystem. This doesn't apply to `@wwtelescope/engine`, which uses UMD module structure (which is compatible with Node/CJS), and it doesn't seem to work with the Vue components, where it's less of a priority since we don't really expect other packages to depend on them. It seems that the current recommendation is to compile to ESM and potentially transpile to CJS if that's needed. We could look into providing both CJS and ESM files, which seems increasingly common these days, but I don't have a sense for much much we need that. The change here should at least make our files more correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like it is more correct to add
type: moduleto the TypeScript-based non-Vue packages.At the moment we're not looking to changing anything about the code in the packages we're distributing, just trying to describe the package contents more correctly.