-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onPressSignup breaks the card swap functionality #13
Comments
Hello @acerbetti,
As you can see in the code itself, it simply changes the state to handle SignUp card and Login card. |
thank you for the quick reply, but you can see that the props "onPressSignup" is also passed to the "BottomContainer" overriding the "setCardState" code and breaking the functionality |
Oh I see. Actually it does not break the functionality, as you can see it just |
Why do you think it breaks the functionality? |
Renaming the props on the BottomContainer should do the trick, but I think that is confusing to use the same callback "onPressLogin" on both login and signup flow. Broken functionality is because if I pass the props onPressSignup to the LoginScreen, the toggle is not responding anymore |
Oh, I will fix that ASAP then. I did not know that. I have a plan to re-write the whole library with Typescript, I will also fix this with that. Thank you for the contribution @acerbetti :) I believe I can make it tomorrow. |
Hello @acerbetti, Release 2.0.3 🥳 |
Hi, thank you for this lib, I cannot understand well how do you set the callback for the signup flow?
Do you have a working example?
thanks
The text was updated successfully, but these errors were encountered: