New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginator data change causes additional fetch #17

Closed

Wtower opened this issue Dec 21, 2016 · 0 comments

Assignees

Owner

Wtower commented Dec 21, 2016

https://github.com/Wtower/ng-gentelella/blob/v0.2.2/gentelella/ga-paginate/ga-paginate.component.js#L68

        self.rePaginate(self.previousCount);

Currently rePaginate accepts one argument. If true, it calls the callback to fetch data. This is used in two places:

When the user changes page
On doCheck, which, because of the initial previousCount check, it occurs when the controller bindings change; mostly the count. Therefore no parameter (false) is necessary.

The text was updated successfully, but these errors were encountered:

Wtower self-assigned this

Wtower closed this as completed in

b2f887d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment