feat: Annotate Outer Void items [skip ci] #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why not? I think the pattern is really strict, so it should not be a problem. |
I was originally thinking in case they added the tag to gear you get from outer void, but thinking about it again they probably would've done that now and GearAnnotator will catch it once they're added to the API anyway |
ryanzhoudev
approved these changes
Jan 2, 2025
kristofbolyai
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 unique items in the 2nd screenshot are annotated as UnknownGearItem so can't really do anything about that unless we make this annotator a higher priority but I don't think that makes sense.
This is just to get the item highlight on them, don't think there's anything else we can do with them at the moment