fix: Mark config and storage saving as synchronized [skip ci] #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking into storage files not being written, this is a race I could think of. I honestly don't think this causes the infrequent issue of long storage files cutting off, but from everything I can see, we correctly open, flush and close streams.
ShadowCat117
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Hopefully this one will be the fix :D
Something I did mention on Discord was maybe we should store crowd sourcing in their own files instead of in storage so even if this doesn't solve it at least that wouldn't be affecting anything "important" if it failed to save properly. That'll take more work though so we'll just hope this works for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into storage files not being written, this is a race I could think of. I honestly don't think this causes the infrequent issue of long storage files cutting off, but from everything I can see, we correctly open, flush and close streams.