Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get relative path in Xmf\Module\Helper\GenericHelper path() method #39

Open
zyspec opened this issue Nov 18, 2017 · 3 comments

Comments

@zyspec
Copy link

zyspec commented Nov 18, 2017

Enhancement
It would be useful in some instances (for example when adding scripts using $xoTheme->addScript() with browse.php) to be able to get the module's relative path to the XOOPS root.

Propose adding a parameter to the GenericModuleHelper path() method to include a 'relative' parameter... something similar to:

    public function path($path = '', $relative = false)
    {
        $path = '/modules/' . $this->dirname . '/' . $path;
        return ($relative) ? $path : XOOPS_ROOT_PATH . $path;
    }

This is backward compatible with existing XMF / module implementations.

@zyspec
Copy link
Author

zyspec commented Nov 3, 2019

Can I ask why this was closed? It's not the same as #65

@mambax7
Copy link
Contributor

mambax7 commented Nov 4, 2019

After I merged the #65, it was closed automatically. I can reopen it again...

@mambax7 mambax7 reopened this Nov 4, 2019
@geekwright
Copy link
Collaborator

Can I ask why this was closed? It's not the same as #65

My bad. I grabbed the wrong issue and added it to the commit comment. I thought I had changed it, but it survived. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants