Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v1.0.0-RC1 of go.opentelemetry.io/otel #15

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Conversation

rcrowe
Copy link
Contributor

@rcrowe rcrowe commented Jun 21, 2021

No description provided.

@rcrowe rcrowe changed the title Support v1.0.0-RC1 Upgrade to v1.0.0-RC1 of go.opentelemetry.io/otel Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #15 (a206aa4) into main (91aaf4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files          11       11           
  Lines         309      309           
=======================================
  Hits          254      254           
  Misses         45       45           
  Partials       10       10           
Impacted Files Coverage Δ
config.go 100.00% <ø> (ø)
conn.go 79.31% <ø> (ø)
stmt.go 82.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91aaf4e...a206aa4. Read the comment docs.

@XSAM
Copy link
Owner

XSAM commented Jun 25, 2021

Thanks for raising this PR.

Please run make precommit before commit. And, we should also change the go.mod in the example folder.

@XSAM XSAM self-requested a review June 25, 2021 07:31
@davidgwcurve
Copy link

Just a FYI that I am blocked upgrading to OTEL v1.0.0-RC1 in our repositories waiting on this MR :)

@XSAM
Copy link
Owner

XSAM commented Jun 25, 2021

Just a FYI that I am blocked upgrading to OTEL v1.0.0-RC1 in our repositories waiting on this MR :)

Sorry for the late upgrade. I kind of busy recently. I can help with this PR to merge.

@XSAM XSAM merged commit 9f73f5d into XSAM:main Jun 25, 2021
@XSAM
Copy link
Owner

XSAM commented Jun 25, 2021

Thanks for your contribution! @rcrowe

@XSAM XSAM mentioned this pull request Jun 25, 2021
@rcrowe rcrowe deleted the v1.0.0-RC1 branch June 26, 2021 07:21
@davidgwcurve
Copy link

Just a FYI that I am blocked upgrading to OTEL v1.0.0-RC1 in our repositories waiting on this MR :)

Sorry for the late upgrade. I kind of busy recently. I can help with this PR to merge.

thank you for doing this! Unblocked now and looking good 🎉 . Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants