Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Refactor tests in app/router #4019

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Chore: Refactor tests in app/router #4019

merged 1 commit into from
Nov 25, 2024
+30 −25

Conversation

zonescape
Copy link
Contributor

I refactored geoip.dat & geosite.dat reading in app/router tests.

Improvements:

  • drop init() functions, use more straightforward code
  • don't copy geoip.dat & geosite.dat

@RPRX RPRX requested a review from yuhan6665 November 18, 2024 03:59
@RPRX
Copy link
Member

RPRX commented Nov 20, 2024

@yuhan6665 话说你的 TG 咋也未读

@yuhan6665 yuhan6665 merged commit 034a485 into XTLS:main Nov 25, 2024
36 checks passed
@yuhan6665
Copy link
Member

@zonescape Thanks looks good to me!
@RPRX I'm too busy from work and family. Need a Quiet Week with the TG from time to time

@RPRX
Copy link
Member

RPRX commented Nov 25, 2024

@yuhan6665 @Fangliding 你们哪位弄一下 #4000 (comment)

@BrewTestBot BrewTestBot mentioned this pull request Nov 30, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhan6665 yuhan6665 Awaiting requested review from yuhan6665

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zonescape @RPRX @yuhan6665