Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: remove product confirmation modal displays out of viewport #207

Open
KFie opened this issue Aug 14, 2023 · 2 comments
Open

Mobile: remove product confirmation modal displays out of viewport #207

KFie opened this issue Aug 14, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@KFie
Copy link

KFie commented Aug 14, 2023

Environment: mobile (here: Nokia 7.1, Android 10; iPhone 12 mini, iOS 16.3.1)

Reproduce:

  1. Add random item to cart
  2. Open cart
  3. Click delete icon

Issue: note the remove product confirmation modal displays on the very top of the page, thus it is not within the user's viewport.

On iPhone 12 mini, iOS 16.3.1., the modal is visible but doesn't have the correct shape:

iOS:
2023-08-14_10h52_31

Android:
2023-08-14_10h54_25

@KFie KFie added the bug Something isn't working label Aug 14, 2023
@rschwietzke rschwietzke added this to the 2.1.0 - Bugfix 1 milestone Dec 6, 2023
@freddyka
Copy link
Contributor

Issue not fixed for poster v2.1.

-->reason is that mobile menu button can't be used (see#199)

@EliasTatX
Copy link
Contributor

The issue is still open as of v2.2. While, unlike before, the top navigation on mobile works in v2.2 which allows normal navigation to this element this is unrelated to the issue. The modal displays at the top of the current FoV meaning it is always in sight of the user. However in portrait view (horizontal orientation) it is still not intuitive to see the modal on the top as opposed to where one clicked on the remove button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

4 participants