This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat(security): treat negotiation succeed if server is old version #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the client is new version with authentication and enables it, and server is old version, which doesn't has the rpc code
RPC_NEGOTIATION
. The client will sends negotiation message when it starts, and server will return errorERR_HANDLER_NOT_FOUND
, then the session will be reset.Here is the corresponding error log:
Same with the situation which server disables authentication. In this case, the server will return
negotiation_status.SASL_AUTH_DISABLE
to client.