refactor(backup): move cold_backup_context out to standalone file (#619)

XiaoMi · Sep 9, 2020 · 0e5e6d4 · 0e5e6d4
1 parent 6d4f9c4
commit 0e5e6d4
Show file tree

Hide file tree

Showing 13 changed files with 1,491 additions and 1,436 deletions.
diff --git a/src/common/replication_common.cpp b/src/common/replication_common.cpp
@@ -115,8 +115,6 @@ replication_options::replication_options()
 
     learn_app_max_concurrent_count = 5;
 
-    max_concurrent_uploading_file_count = 10;
-
     cold_backup_checkpoint_reserve_minutes = 10;
 }
 
@@ -510,12 +508,6 @@ void replication_options::initialize()
     cold_backup_root = dsn_config_get_value_string(
         "replication", "cold_backup_root", "", "cold backup remote storage path prefix");
 
-    max_concurrent_uploading_file_count =
-        (int32_t)dsn_config_get_value_uint64("replication",
-                                             "max_concurrent_uploading_file_count",
-                                             max_concurrent_uploading_file_count,
-                                             "concurrent uploading file count");
-
     cold_backup_checkpoint_reserve_minutes =
         (int)dsn_config_get_value_uint64("replication",
                                          "cold_backup_checkpoint_reserve_minutes",

diff --git a/src/common/replication_common.h b/src/common/replication_common.h
@@ -116,7 +116,6 @@ class replication_options
     int32_t learn_app_max_concurrent_count;
 
     std::string cold_backup_root;
-    int32_t max_concurrent_uploading_file_count;
     int32_t cold_backup_checkpoint_reserve_minutes;
 
     std::string bulk_load_provider_root;

diff --git a/src/replica/CMakeLists.txt b/src/replica/CMakeLists.txt
@@ -9,7 +9,8 @@ set(DUPLICATION_SRC
         duplication/mutation_batch.cpp
 )
 
-set(BACKUP_SRC backup/replica_backup_manager.cpp)
+set(BACKUP_SRC backup/replica_backup_manager.cpp
+               backup/cold_backup_context.cpp)
 
 set(BULK_LOAD_SRC bulk_load/replica_bulk_loader.cpp)