Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(build): fix higher version cmake produce filename as 'compiler_depend.ts' bug #1036

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Jan 25, 2022

issue: apache/incubator-pegasus#894

CMake issue: https://discourse.cmake.org/t/base-filename-gets-set-to-compiler-depend-ts-after-update-to-cmake-3-20/3075
This patch is inspired by: https://stackoverflow.com/questions/1706346/file-macro-manipulation-handling-at-compile-time/27990434#27990434

Before and after this patch, logs look like:

==> replica.log.20220125_135753_521 <==
D2022-01-25 13:57:53.521 (1643090273521305878 2cff) unknown.io-thrd.11519: compiler_depend.ts:466:run(): process(11519) start: 1643090273510, date: 2022-01-25 13:57:53.510
D2022-01-25 13:57:53.527 (1643090273527174447 2cff) unknown.io-thrd.11519: compiler_depend.ts:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 13:57:53.527 (1643090273527188517 2cff) unknown.io-thrd.11519: compiler_depend.ts:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_TCP, fmt = NET_HDR_DSN ...
D2022-01-25 13:57:53.527 (1643090273527382792 2cff) unknown.io-thrd.11519: compiler_depend.ts:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 13:57:53.527 (1643090273527507816 2cff) unknown.io-thrd.11519: compiler_depend.ts:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_UDP, fmt = NET_HDR_DSN ...
D2022-01-25 13:57:53.527 (1643090273527571287 2cff) unknown.io-thrd.11519: compiler_depend.ts:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 13:57:53.527 (1643090273527574518 2cff) unknown.io-thrd.11519: compiler_depend.ts:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_TCP, fmt = NET_HDR_HTTP ...
D2022-01-25 13:57:53.527 (1643090273527636049 2cff) unknown.io-thrd.11519: compiler_depend.ts:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 13:57:53.527 (1643090273527718361 2cff) unknown.io-thrd.11519: compiler_depend.ts:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_UDP, fmt = NET_HDR_HTTP ...
D2022-01-25 13:57:53.527 (1643090273527833455 2cff) unknown.io-thrd.11519: compiler_depend.ts:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")

==> replica.log.20220125_140519_904 <==
D2022-01-25 14:05:19.905 (1643090719905055901 4c17) unknown.io-thrd.19479: service_api_c.cpp:466:run(): process(19479) start: 1643090719897, date: 2022-01-25 14:05:19.897
D2022-01-25 14:05:19.909 (1643090719909423329 4c17) unknown.io-thrd.19479: rpc_address.cpp:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 14:05:19.909 (1643090719909439759 4c17) unknown.io-thrd.19479: rpc_engine.cpp:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_TCP, fmt = NET_HDR_DSN ...
D2022-01-25 14:05:19.909 (1643090719909622064 4c17) unknown.io-thrd.19479: rpc_address.cpp:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 14:05:19.909 (1643090719909726877 4c17) unknown.io-thrd.19479: rpc_engine.cpp:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_UDP, fmt = NET_HDR_DSN ...
D2022-01-25 14:05:19.909 (1643090719909835350 4c17) unknown.io-thrd.19479: rpc_address.cpp:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 14:05:19.909 (1643090719909839430 4c17) unknown.io-thrd.19479: rpc_engine.cpp:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_TCP, fmt = NET_HDR_HTTP ...
D2022-01-25 14:05:19.909 (1643090719909865791 4c17) unknown.io-thrd.19479: rpc_address.cpp:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")
D2022-01-25 14:05:19.909 (1643090719909936523 4c17) unknown.io-thrd.19479: rpc_engine.cpp:481:start(): [replica] network client started at port 3, channel = RPC_CHANNEL_UDP, fmt = NET_HDR_HTTP ...
D2022-01-25 14:05:19.910 (1643090719910055396 4c17) unknown.io-thrd.19479: rpc_address.cpp:122:ipv4_from_network_interface(): get ip address from network interface(eth0), addr(x.x.x.x), input interface("")

@acelyc111 acelyc111 merged commit df4af63 into XiaoMi:master Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants