This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
fix(bulk_load): fix bug that poping all committed mutations ineffective #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in succeed stage (XiaoMi#958)
…low_ingest_behind (XiaoMi#991)
… ingestion_context class (XiaoMi#1035)
hycdong
changed the title
fix(bulk_load): fix pop all committed mutation not work
fix(bulk_load): fix poping all committed mutations ineffective
May 10, 2022
levy5307
changed the title
fix(bulk_load): fix poping all committed mutations ineffective
fix(bulk_load): fix bug that poping all committed mutations ineffective
May 10, 2022
foreverneverer
approved these changes
May 11, 2022
acelyc111
approved these changes
May 11, 2022
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pegasus#872 In bulk load process, all refactors of replica will download sst files and ingest them into rocksdb. After the ingestion, we will send an empty write and pop all committed mutations in prepare list to let learn process will always start from learn checkpoint.
However, according to the community usage, we found that pop all committed mutation not work, this pull request fixs it, including: