Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(bulk_load): fix bug that poping all committed mutations ineffective #1102

Merged
merged 26 commits into from
May 12, 2022

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented May 7, 2022

Pegasus#872 In bulk load process, all refactors of replica will download sst files and ingest them into rocksdb. After the ingestion, we will send an empty write and pop all committed mutations in prepare list to let learn process will always start from learn checkpoint.
However, according to the community usage, we found that pop all committed mutation not work, this pull request fixs it, including:

  • Sending another empty write after generate checkpoint. The formal first empty write is used to let secondary commit ingestion request, the new secondary empty write is to do real pop action.
  • Secondary replica will also execute pop all committed mutation action, which is not implemented in old version.

empiredan and others added 26 commits October 25, 2021 17:15
@hycdong hycdong changed the title fix(bulk_load): fix pop all committed mutation not work fix(bulk_load): fix poping all committed mutations ineffective May 10, 2022
@levy5307 levy5307 changed the title fix(bulk_load): fix poping all committed mutations ineffective fix(bulk_load): fix bug that poping all committed mutations ineffective May 10, 2022
@hycdong hycdong merged commit 51900ce into XiaoMi:master May 12, 2022
@hycdong hycdong deleted the fix_pop_all branch May 12, 2022 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants