This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
requested review from
neverchanje,
qinzuoyan,
acelyc111,
foreverneverer and
vagetablechicken
July 30, 2019 07:30
neverchanje
reviewed
Jul 31, 2019
src/dist/replication/test/meta_test/unit_test/meta_split_service_test_helper.h
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Jul 31, 2019
src/dist/replication/test/meta_test/unit_test/meta_split_service_test.cpp
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Jul 31, 2019
src/dist/replication/test/meta_test/unit_test/meta_split_service_test.cpp
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Aug 1, 2019
neverchanje
reviewed
Aug 5, 2019
neverchanje
approved these changes
Aug 5, 2019
vagetablechicken
approved these changes
Aug 6, 2019
This was referenced Aug 6, 2019
Closed
This was referenced Feb 14, 2020
This was referenced Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple partition split process
More partition split discussion in issue #69
This pr solves the first step of partition split, which is bold in process description.
Main code logic
When meta server receives a partition split request:
Other explanations