This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: move primary's learning preparation of cache into another function #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
force-pushed
the
learnrefact
branch
from
f561b4f
to
27cba8c
Compare
neverchanje
changed the title
neverchanje
force-pushed
the
learnrefact
branch
from
fb53b9b
to
738e588
Compare
neverchanje
changed the title
levy5307
reviewed
Mar 1, 2021
src/replica/replica_learn.cpp
Outdated
| count, | ||
| response.state.meta.length()); | ||
| } | ||
|
|
||
| // learn delta state or checkpoint | ||
| // in this case, the state on the PS is still incomplete |
There was a problem hiding this comment.
hycdong
reviewed
Mar 1, 2021
| learner_state, | ||
| response, | ||
| delayed_replay_prepare_list); | ||
| if (!should_learn_cache) { | ||
| if (learn_start_decree > _app->last_durable_decree()) { |
There was a problem hiding this comment.
It seems that the comments are for condition if (learn_start_decree > _app->last_durable_decree()) in line 449, it is better to move comments between line 448 and line 449.
// learn delta state or checkpoint
// in this case, the state on the PS is still incomplete
There was a problem hiding this comment.
I think "delta state" stands for log and cache. So it's still reasonable to see this comment stands above L442. I don't know what's the initial intention of this comment.
There was a problem hiding this comment.
Sounds reasonable~ I recommend removing comment // in this case, the state on the PS is still incomplete which is useless and confusing.
hycdong
approved these changes
Mar 3, 2021
foreverneverer
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.