This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: reduce netprovider unit test executing time #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Oct 21, 2020
neverchanje
reviewed
Oct 22, 2020
Comment on lines
+279
to
+280
| // not exceed threshold | ||
| for (int count = 0; count < CONN_THRESHOLD + 2; count++) { |
There was a problem hiding this comment.
Why doesn't it exceed threshold when sessions count == CONN_THRESHOLD +2?
There was a problem hiding this comment.
Acutually, the count doesn't matter in not-exceed case, it will first create a client to create a new session, then close the session, so it will not exceed connection threshold, the count here only means the loop count.
neverchanje
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pegasus issue 567 shows, there are some unit tests are time-cosuming,
tools_common.asio_network_provider_connection_thresholdis one of them, it will cost 70017ms. This pull request is a refactor of this unit test to reduce its executing time, it will cost 2077ms to run this unit test.