Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: incorrect help info of meta/replica remote commands #808

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Apr 2, 2021

-------------------------------------------------
help|Help|h|H [command] - display help information
help|Help|h|H [command] - display help information
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
config-dump - dump configuration
engine - get engine internal information
fd.allow_list
flush-log - flush log to stderr or log file
help|Help|h|H [command] - display help information
help|Help|h|H [command] - display help information
dump: dump app_states of meta server to local file
lb.add_secondary_enable_flow_control <true|false>
lb.add_secondary_max_count_for_one_node [num | DEFAULT]
lb.assign_delay_ms [num | DEFAULT]
lb.assign_secondary_black_list [<ip:port,ip:port,ip:port>|clear]
lb.balancer_in_turn <true|false>
lb.get_balance_operation_count [total | move_pri | copy_pri | copy_sec | detail]
lb.ignored_app_list <get|set|clear> [app_id1,app_id2..]
lb.only_move_primary <true|false>
lb.only_primary_balancer <true|false>
live_percentage [num | DEFAULT]
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
perf-counters - query perf counters, filtered by OR of POSIX basic regular expressions
perf-counters-by-postfix - query perf counters, filtered by OR of postfix strings
perf-counters-by-prefix - query perf counters, filtered by OR of prefix strings
perf-counters-by-substr - query perf counters, filtered by OR of substrs
profiler.query|pq - query profiling data, output in json format
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profiler.query|pq - query profiling data, output in json format
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
reset-log-start-level - reset the log start level
server-info - query server information
server-stat - query selected perf counters
system.queue - get queue internal information
task-code - query task code containing any given keywords

This was the help info of remote commands. Commands like "lb.add_secondary_enable_flow_control" are actually not existed.
It was due to the modification of a former refactoring #522 that didn't accordingly update the help info. It certainly will make system admin puzzled about the usage.

After this PR, the help info of meta remote commands become:

CALL [meta-server] [127.0.0.1:34602] succeed: help|Help|h|H [command] - display help information
help|Help|h|H [command] - display help information
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
config-dump - dump configuration
engine - get engine internal information
fd.allow_list
flush-log - flush log to stderr or log file
help|Help|h|H [command] - display help information
help|Help|h|H [command] - display help information
meta.dump - dump app_states of meta server to local file
meta.lb.add_secondary_enable_flow_control <true|false>
meta.lb.add_secondary_max_count_for_one_node [num | DEFAULT]
meta.lb.assign_delay_ms [num | DEFAULT]
meta.lb.assign_secondary_black_list [<ip:port,ip:port,ip:port>|clear]
meta.lb.balancer_in_turn <true|false>
meta.lb.get_balance_operation_count [total | move_pri | copy_pri | copy_sec | detail]
meta.lb.ignored_app_list <get|set|clear> [app_id1,app_id2..]
meta.lb.only_move_primary <true|false>
meta.lb.only_primary_balancer <true|false>
meta.live_percentage [num | DEFAULT]
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
perf-counters - query perf counters, filtered by OR of POSIX basic regular expressions
perf-counters-by-postfix - query perf counters, filtered by OR of postfix strings
perf-counters-by-prefix - query perf counters, filtered by OR of prefix strings
perf-counters-by-substr - query perf counters, filtered by OR of substrs
profiler.query|pq - query profiling data, output in json format
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profiler.query|pq - query profiling data, output in json format
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
reset-log-start-level - reset the log start level
server-info - query server information
server-stat - query selected perf counters
system.queue - get queue internal information
task-code - query task code containing any given keywords

Replica:

help|Help|h|H [command] - display help information
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
config-dump - dump configuration
engine - get engine internal information
flush-log - flush log to stderr or log file
help|Help|h|H [command] - display help information
help|Help|h|H [command] - display help information
nfs.max_copy_rate_megabytes [num | DEFAULT]
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
perf-counters - query perf counters, filtered by OR of POSIX basic regular expressions
perf-counters-by-postfix - query perf counters, filtered by OR of postfix strings
perf-counters-by-prefix - query perf counters, filtered by OR of prefix strings
perf-counters-by-substr - query perf counters, filtered by OR of substrs
profiler.query|pq - query profiling data, output in json format
profile|Profile|p|P - performance profiling
profiler data - get appointed data, using by pjs
profiler.query|pq - query profiling data, output in json format
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
repeat|Repeat|r|R interval_seconds max_count command - execute command periodically
replica.deny-client <true|false>
replica.kill_partition [app_id [partition_index]]
replica.max-concurrent-bulk-load-downloading-count [num | DEFAULT]
replica.mem-release-max-reserved-percentage [num | DEFAULT]
replica.query-app-envs [id1,id2,...] (where id is 'app_id' or 'app_id.partition_id')
replica.query-compact [id1,id2,...] (where id is 'app_id' or 'app_id.partition_id')
replica.release-tcmalloc-memory <true|false>
replica.trigger-checkpoint [id1,id2,...] (where id is 'app_id' or 'app_id.partition_id')
replica.verbose-client-log <true|false>
replica.verbose-commit-log <true|false>
reset-log-start-level - reset the log start level
server-info - query server information
server-stat - query selected perf counters
system.queue - get queue internal information
task-code - query task code containing any given keywords

@neverchanje neverchanje changed the title fix: help info of meta remote commands fix: incorrect help info of meta/replica remote commands Apr 2, 2021
@neverchanje neverchanje merged commit d1caa13 into XiaoMi:master Apr 2, 2021
@neverchanje neverchanje deleted the fixmetacmd branch April 2, 2021 10:59
@hycdong hycdong added the 2.2.0 label Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants