This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(load-balance): update selection strategy for max load disk #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cluster load balance, we will try to migrate partition from
max_node
who has the max replica count tomin_node
, then we would like to pick up amax_load_disk
who has the max replica count inmax_node
.The old pickup strategy, if different disks hold same replica count, it will chosse the first one.
Just as the example shows,
ssd1
will be choosen. However, 2.1 and 2.2 have already exsited in min_node, so there won't be any partition to be moved.This pr fixs the problem above. We use
get_max_load_disk_set
to get a disk set.ssd1
andssd2
will be included in the set. Thenpick_up_move
will choose one of them randomly.